2048.cpp icon indicating copy to clipboard operation
2048.cpp copied to clipboard

Change tile width dynamically to allow longer strings

Open Scronkfinkle opened this issue 7 years ago • 8 comments
trafficstars

The table will now draw to the longest length number with a small border of spaces

Resolves #54

Scronkfinkle avatar Oct 23 '18 14:10 Scronkfinkle

Thank you for your contribution! :tada: The following will be a quick code review, ok?

cawvyoct avatar Oct 23 '18 15:10 cawvyoct

Alright, I'll fix it up when I get home from work in a few hours

Scronkfinkle avatar Oct 23 '18 16:10 Scronkfinkle

So, things are a bit confusing here with the authors of commits in this PR. Suggestions of "things to fix" before hard edits would have been preferred...
(This fosters encouragement of committer to correct missing tasks using own abilities).

cawvyoct avatar Oct 24 '18 18:10 cawvyoct

My apologies @cawvyoct 😐! I saw a few things that could be counted as quick-fixes so I did it myself. I'll keep this in mind, thank you.

plibither8 avatar Oct 24 '18 19:10 plibither8

@plibither8 Do you want to handle these changes or shall I? I don't mind either way, I just don't want us both to accidentally push upstream at once

Scronkfinkle avatar Oct 25 '18 12:10 Scronkfinkle

Go ahead, I guess it's better since you've created the PR. I have some other work right now, won't be able to work on this until later. Thanks 👍

plibither8 avatar Oct 25 '18 12:10 plibither8

constexpr int CELL_BORDER = 1;

This works too, however enums are great for newer developers to understand that some variables have a group context together.

cawvyoct avatar Oct 28 '18 19:10 cawvyoct

Hi @Scronkfinkle, Just an update, but thanks for your contributions so far to the project! :+1: Currently, the game's codebase is being refactored quite a bit and you will need to update your PR to match the new refactored code (when code refactoring slows down quite a bit).

Dynamic-width tiles are still very much a challenge open for you if you wish. I think even when more refactored code lands into the codebase, your skill / help would be fine in completing it. :cat:

cawvyoct avatar Nov 02 '18 01:11 cawvyoct