Arne Brasseur

Results 300 comments of Arne Brasseur

Thanks for the report, I had a look but it isn't immediately trivial to fix, and I don't want to put much more effort into Facai. I also failed to...

Martin! Long time no see :D Remove all handlers (bit hacky, no better API for this at the moment. PR welcome to add a proper function for this) ```clj (->>...

You're right, having a key similar to e.g. in add-watch would be more convenient, that's usually how I set up these kind of APIs, but I guess here I didn't....

I definitely agree we want something like this. Currently we expect a trait to be a map, namely a template map that gets merged in. But how do you provide...

That all makes sense, I think I need to dive into the factory bot sources a bit for inspiration. Regarding execution order, Intuitively I would say - Traits are meant...

That's the case that I tried to explain above, if `:trait-that-sets-bar-to-55` has a hook, should that hook see a value with `:bar 55`, or with `:bar 100`? I would assume...

I've partially implemented this in #3, main things missing: - traits depending on other traits - after-create hooks I'm going to punt on the after create hooks, I think for...

One point in particular that I would like input on is the syntax, I'd like to provide a shorter alternative to always having to enter `(my-factory {:with ...})`, but not...

Even though this isn't exactly fully baked I'm merging this now, since we're proceeding with the rename to Harvest, and this will be a pain to merge afterwards.

I've removed this commit from `main` here, instead deciding to keep facai stable and not have any more breaking changes. Since we're renaming anyway we can do new development under...