Parity with `eslint-plugin-jest`

[unlikelyzero]

trafficstars

We're establishing coding practices for our e2e suite before opening it up to the public. Generally, we're looking to enforce these code practices wherever possible and would likely need most of the rules from the Jest ESLint plugin.

• [ ] expect-expect
• [ ] max-expects
• [ ] no-commented-out-tests
• [ ] no-conditional-expect
• [ ] no-duplicate-hooks
• [ ] no-hooks
• [x] #91
• [ ] no-standalone-expect
• [ ] prefer-comparison-matcher
• [ ] prefer-equality-matcher
• [ ] prefer-hooks-in-order
• [ ] prefer-hooks-on-top
• [x] #85
• [x] #103
• [x] #104
• [ ] prefer-to-contain
• [x] #93
• [ ] require-hook
• [ ] require-to-throw-message
• [x] #84
• [ ] valid-describe-callback
• [ ] valid-expect-in-promise
• [ ] valid-title

Probably don't need these

• [ ] no-test-return-statement
• [ ] no-large-snapshots

[unlikelyzero]

@mskelton hey, would you mind undoing the reformatting? I was using it to visual scan for changes from the jest dir. I had 2 i needed to add from their recent deployment

[mskelton]

@unlikelyzero The reason I changed it was so we can use GitHub's feature to convert a list item into an issue for tracking. Will make it much easier to see progress as we work through the list creating and closing issues for each of these features.

Can we just add the new rules to the end of the list?

[unlikelyzero]

@mskelton in this case, I think we should have a near-synchronous discussion on the the purpose of this ticket. this ticket initially was supposed to be a one-time audit and a conversation about what is applicable to this project. I think all of that work has been undone

[mskelton]

After a year and a half of opening this issue, I'm happy to report I've finished the last of the remaining lint rules!