play-scala-react-seed
play-scala-react-seed copied to clipboard
playframework
Adds Dockerization instructions to README.
Adds README instructions for dockerizing the play-react app.
I contained the information all within the Readme, since the modifications are generally only something you want if you're going to be running your app in a container. Not sure if you'd prefer another method of adding these instructions. I just went through this process so I thought I'd capture it by adding it somewhere. The section added to the README is relatively substantial, so if there's a more appropriate way to share this information, let me know (scala-play-react-docker-seed?)
@Lugghawk great contribution. It's better if you can move this to another md file and link it to the primary (readme.md). Also, the same should be reflected in other related seed projects.
scala-play-angular-seed java-play-react-seed java-play-angular-seed
@Lugghawk Quite a while has passed since your PR, since we moved the repository under Play Framework organization we are trying to get it updated. I would think that the Docker setup is important enough that we should not only just have docs for it, but have it included in the main build. Would you like to work on that?
@ptrdom I'm not sure what's involved, but with a bit of guidance I could give it a shot.
What does it mean to be "included in the main build"? Should this doc PR be retargeted somewhere else?
What does it mean to be "included in the main build"?
Oh, I meant just that we could actually implement the changes that you documented, instead of only documenting what is required to be implemented and leaving the implementation up to the user of this seed project. What do you think about that?
Should this doc PR be retargeted somewhere else?
This is the main repo now, as you can see it is under playframework organization already.
instead of only documenting what is required to be implemented and leaving the implementation up to the user of this seed project.
Ah! So you'd like it to be the new default. That sounds fine to me, I can try and work on those changes over the next few days. Shall I append it to this same PR (with a more appropriate title/etc) or should I close and start a new one?