platformio-core icon indicating copy to clipboard operation
platformio-core copied to clipboard

Fix can't match the last+on some boards.

Open Tokisaki-Galaxy opened this issue 1 year ago • 1 comments

Fixed an error in the old regular expression that the+at the end could not be matched on some boards.

cannot-matched-issue

For example, when I use STC89C516RD+, I will get an error, because the old regular expression regards the+at the end as an error.

Tokisaki-Galaxy avatar Aug 27 '24 12:08 Tokisaki-Galaxy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 27 '24 12:08 CLAassistant

Hi, I noticed an issue that seems to cause significant problems. Users are unable to use development boards with '+' at the end of their names. This can be quite limiting for those who rely on such boards.

I wanted to follow up and ask if there are any concerns or reasons why the PR has not been merged yet. If there are any changes or improvements needed, please let me know, and I would be happy to make the necessary adjustments.

Thank you for your attention to this matter. I really like this project.

Best regards, tokisaki

Tokisaki-Galaxy avatar Sep 29 '24 08:09 Tokisaki-Galaxy

Resolved in https://github.com/platformio/platform-intel_mcs51/commit/ad5d629c010841bbf1ee6f6e65207d8775e4e7cb

ivankravets avatar Oct 04 '24 09:10 ivankravets

It never seems to be resolved. Only STC89C516RD+ can be chose, and there's no STC89C516RD.

calyle avatar Aug 16 '25 19:08 calyle

It never seems to be resolved. Only STC89C516RD+ can be chose, and there's no STC89C516RD.

I believe you are correct. If you look at the commit that was mentioned when this PR was closed, the fix was to rename the board's definition file directly, rather than changing the regular expression as originally proposed.

This is why the STC89C516RD+ board now appears, but the original STC89C516RD is gone. The underlying validation issue still remains.

Tokisaki-Galaxy avatar Oct 14 '25 11:10 Tokisaki-Galaxy