vtprotobuf icon indicating copy to clipboard operation
vtprotobuf copied to clipboard

Published 20 hours ago • verified publisher icon planetscale

Add string utf-8 validation

Open tamayika opened this issue 5 months ago • 2 comments

closes #146

Adding string utf-8 validation. This change makes vtprotobuf to align the other protobuf implementations.(e.g. protobuf-go, protobuf-cpp, etc)

tamayika avatar Jun 16 '25 08:06 tamayika

If we did introduce this, it would have to be done as a flag to opt into this behavior since it's a breaking change. Even tho it's more correct, people (including us unfortunately) depend on this incorrect behavior. This originally came from the gogoproto implementation which also did not validate for UTF-8 strings.

But as is, this absolutely would break Vitess.

mattrobenolt avatar Jun 16 '25 09:06 mattrobenolt

Thank you for the review!

I added generator option to keep the current behavior.

tamayika avatar Jun 16 '25 14:06 tamayika

@mattrobenolt I'm sorry to bother you, but could you please review it again?

tamayika avatar Jun 30 '25 09:06 tamayika

@mattrobenolt I'm sorry to bother you again, but could you please review it again?

tamayika avatar Jul 13 '25 14:07 tamayika

@mattrobenolt @vmg I'm sorry to bother you again, but could you please review it again?

tamayika avatar Aug 02 '25 06:08 tamayika