draino icon indicating copy to clipboard operation
draino copied to clipboard

filter out pod in eviction using pod ownerreference kind

Open dbenque opened this issue 5 years ago • 4 comments

Fix issue #98

It is now possible to define eviction exclusion based on the pod ownerReference type. This open the door for more control on pods that are controlled by CRD.

example:

        --do-not-evict-pod-controlled-by=StatefulSet
        --do-not-evict-pod-controlled-by=DaemonSet
        --do-not-evict-pod-controlled-by=ExtendedDaemonSet
        --do-not-evict-pod-controlled-by=

This set of flags replace previous flag:

       --evict-daemonset-pods=false
       --evict-statefulset-pods=false
       --evict-unreplicated-pods=false

and adds an exclusion on kind=ExtendedDaemonSet

The default values have been set to match historical behavior.

dbenque avatar Oct 01 '20 10:10 dbenque

Codecov Report

:exclamation: No coverage uploaded for pull request head (david.benque/issue98-do-not-evict-pod-controlled-by@df8c0d9). Click here to learn what that means. The diff coverage is n/a.

codecov[bot] avatar Oct 01 '20 11:10 codecov[bot]

@jacobstr , I cannot get access to the code coverage report. Codecov is complaining that the project is not public (looks like it is... ). Is there any settings you can change so that we can read the report?

Also I am going to add some test to the util.go in the meantime.

dbenque avatar Oct 01 '20 11:10 dbenque

@dbenque there seem to be no permissions related to view access outside of making in a collaborator - which I can't do unilaterally. Perhaps there's some workaround e.g. setting it up for your fork?

I realize it's not a great story for contributors if you have to guess and and check to pass the CI flow in an MR.

jacobstr avatar Oct 01 '20 18:10 jacobstr

@jacobstr I don't know if you did something, but now I have access to the report. It is going to be difficult to add more relevant test. What is the policy here? are you going to block progress/merge under a given threshold ?

dbenque avatar Oct 06 '20 14:10 dbenque