Plan icon indicating copy to clipboard operation
Plan copied to clipboard

Add support for server defined join address groups

Open Josh65-2201 opened this issue 1 year ago • 1 comments

I would like to be able to..

I would like if the server config could have predefined groups that can have user control visibility in addition to user adding there own

join_groups:
    group_name: (show _ as a space in the UI)
        "url/ip"

Is your feature request related to a problem? Please describe.

It very easy to lose groups and having some server defined ones give everyone viewing same data.

Josh65-2201 avatar Jul 13 '24 22:07 Josh65-2201

This has turned out to be surprisingly complicated since each server has its own join address list 🤔 I would assume server owner would like to configure all groups in one place on networks with multiple servers, but adding uuids to the config seems a bit cumbersome - and reusing one default group from the config for all servers doesn't seem to make sense

AuroraLS3 avatar Jul 15 '24 18:07 AuroraLS3

Yeah this kinda needs to be done. The Join Addresses page is basically useless if it doesn't remember what I'm trying to track. On top of that, it seems that I can't add more than one address into an "Address Group" in the page either.

ZepsiZola avatar Oct 06 '25 09:10 ZepsiZola

On top of that, it seems that I can't add more than one address into an "Address Group" in the page either.

This has been solved in recent dev release. While selecting multiple is possible by holding down ctrl and clicking, it doesn't work on mobile and is unintuitive to users

AuroraLS3 avatar Oct 06 '25 10:10 AuroraLS3

That's good to know. Also for the implementation of the "defined address groups", would it not be possible to just store in the database which address groups the user is tracking? I personally don't think defining it in the config.yml is a good idea.

ZepsiZola avatar Oct 06 '25 10:10 ZepsiZola

That's how it currently works if you have login enabled - The address groups you make are stored in user preferences.

When http only they are stored in browser local storage.

This ticket is more about having default values (or presets) for when you haven't created address groups

AuroraLS3 avatar Oct 06 '25 10:10 AuroraLS3

From what I can tell they wipe when I reload the page. I'm logged in as a user. I have reverse-proxied the webserver so maybe it thinks my instance is http-only? But I did follow the guide on Authentication with reverse-proxy.

ZepsiZola avatar Oct 06 '25 10:10 ZepsiZola

Hmm, sounds like it could be a bug, I'll investigate when working on this ticket.

AuroraLS3 avatar Oct 06 '25 10:10 AuroraLS3

Should I make a bug-report somewhere else? I have a video I can submit of the bug taking place in case I might be doing something wrong.

ZepsiZola avatar Oct 06 '25 10:10 ZepsiZola

https://github.com/user-attachments/assets/50ef2df0-73a4-41f2-856e-112a7a266cfd

ZepsiZola avatar Oct 06 '25 10:10 ZepsiZola