pkp-lib icon indicating copy to clipboard operation
pkp-lib copied to clipboard

pkp/pkp-lib#10090 Ensure anonymity in discussions for double blind reviews

Open Hafsa-Naeem opened this issue 1 year ago • 1 comments

for pkp/pkp-lib#10090

Hafsa-Naeem avatar Sep 12 '24 05:09 Hafsa-Naeem

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 12 '24 05:09 CLAassistant

@Hafsa-Naeem, is the PR ready? If yes, can you update it?

Vitaliy-1 avatar Sep 27 '24 06:09 Vitaliy-1

@Vitaliy-1 Yes, I've made the necessary changes based on your feedback. The PR is now updated and ready for your review, let me know if anything else is needed.

Hafsa-Naeem avatar Sep 27 '24 06:09 Hafsa-Naeem

It still has conflicts with the QueryForm, can you rebase it locally on top of the main, and ping me to merge? E.g. (depending on your setup):

git checkout main
git pull upstream main

depending on what main you are tracking, e.g., you can also update your own own fork's main in the Github interface

git checkout main
git pull origin main

You can always check what branch is tracked by:

git status
git remote -v

And then do rebase and deal with conflicts:

git checkout reviewer_anonimity_bug
git rebase -i main
git push --force 

Vitaliy-1 avatar Sep 30 '24 11:09 Vitaliy-1

@Vitaliy-1 Thank you. I have resolved the conflicts and rebased the branch on top of the main. Please review.

Hafsa-Naeem avatar Oct 01 '24 20:10 Hafsa-Naeem

I don't see any changes comparing with the current main. Probably something got lost during rebase. Can you double check please?

Vitaliy-1 avatar Oct 01 '24 20:10 Vitaliy-1

@Vitaliy-1 I’ve fixed the rebase issues and the changes. Please review. Thanks!

Hafsa-Naeem avatar Oct 02 '24 03:10 Hafsa-Naeem

Thanks! I left comments, I think there is a method that was added to the StageAssignment by mistake

Vitaliy-1 avatar Oct 02 '24 09:10 Vitaliy-1