Constantine Peresypkin

Results 252 comments of Constantine Peresypkin

I can confirm that patching with #773 fixes this problem. (using `runtime: node18.x`) God bless `patch-package`!

@malikas05 I've added PR to ClickHouse to fix that annoying problem :)

It's much much worse than that. It always updates the address in Route53 to a wrong CNAME! That CNAME no longer exists in the cluster, yet `external-dns` will insist on...

Reproduced again, and again, and again. It seems like `external-dns` just doesn't really handle load balancer address change at all. I.e. the one and only functionality it's needed for

It's not a "workaround" it's just a hack for `email dev`, what about `email export`? It doesn't create `.react-email` folder.

Created a patch to solve the problem for both `dev` and `export` (for `1.9.5`): ```patch diff --git a/node_modules/react-email/dist/source/commands/dev.js b/node_modules/react-email/dist/source/commands/dev.js index c0f050a..6e63dd9 100644 --- a/node_modules/react-email/dist/source/commands/dev.js +++ b/node_modules/react-email/dist/source/commands/dev.js @@ -8,16 +8,20 @@...

It's simple: ``` // bufferish-array.js var Bufferish = require("./bufferish"); ``` ``` // bufferish.js var BufferArray = exports.Array = require("./bufferish-array"); ``` Here's the circle. Pretty nasty one. Refactoring out all the...

> @jorgesolebur I believe this is intentional behavior. By setting `continue-on-error` to `true`, you are saying 'pass this step even if it fails'. The if failure specifically looks for steps...

> What specifically does not work anymore? `continue-on-error: true` leads to "green" test. Maybe it's a bug in github actions for some runners. But still, my tests silently failed for...

Yeah, but I don't really want to use some special calling conventions for the "on failure" steps.