pjproject icon indicating copy to clipboard operation
pjproject copied to clipboard

Update for swig/python

Open Axiinos opened this issue 1 year ago • 3 comments

i made changes to make importsym more adaptive, along with checking if the system is win32, if it is, it will ask the user the registered path is correct, if not change it to the correct one, then edit and comment #include<pj/compat/socket.h> for them.

at the same time made changes to setup.py, including automatic execution of transform_docs.py, adding code comments for the user without any hassle.

I have tested the changes against linux and windows, and they seem to function as expected.

however i do still happen to hit a roadblock of the actual process function having issues with _fake_typedefs.h "see screenshot for reference.", which is likely just a setup issue on my end/versioning issues....

Linux version: image

Windows version: image

there is also probably some methods i could have done better, tho i would like to hear feedback on the solution!

Axiinos avatar Oct 01 '24 11:10 Axiinos

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 01 '24 11:10 CLAassistant

I tested it here on Mac and it didn't work either. Unfortunately, I also don't know how to fix it.

sauwming avatar Oct 04 '24 04:10 sauwming

I tested it here on Mac and it didn't work either. Unfortunately, I also don't know how to fix it.

I have tried multiple things, and yes i have followed the build steps to the letter from the guides "they seem sorta lacking when it comes to pjsua2 swig building, like no mention of c++xx version for compiler, which version of pycparser or python 2.x version to use" which could be the potential issue here?

would need more info from those who work on the swig/python side of things to clear it up.

when I use make, I do also get similar result as this bug report does: https://github.com/pjsip/pjproject/issues/4092#issue-2554146276

so if I really want to build the module, I have to just trust a potentially outdated symbolic link file and just force swig to process it.

Axiinos avatar Oct 07 '24 06:10 Axiinos

Thanks for the contribution. But we can't merge it at the moment since there are still some issues with the current patch.

We understand that the existing importsym has some problems that you described in #4054, such as the hardcoded dir and compatibility with Python 3, but importsym.py is not supposed to be executed every time, so it's not urgent to be fixed/changed. Thus, I will close the PR and the issue.

sauwming avatar Nov 12 '24 02:11 sauwming