Paul Dicker
Paul Dicker
> I think this whole issue is superseded by @pnorman's work on the [new flex style](https://github.com/gravitystorm/openstreetmap-carto/pull/4431) True, should have mentioned that. This PR would be useful in the meantime, and...
> I have looked at this a bit and have to say i don't fully understand how it works technically but the combination of using `opacity: 0.99999;` and `mask/line-gamma: 0;`...
The fix is to change a 24 to 23 in `tz_info::rule::parse_offset`.
Of course, and thank you. Removed one commit that in the end didn't do much. As a note: the reason to make everything methods on the `Cache` type is because...
> I've tried to review this, but I've found it challenging. > > Most of the changes don't look like improvements to me -- they mostly add more code, and...
To be honest: while I opened this PR to take over, it is no priority for me. We can add an optional variant or review any time.
Those would be: `NaiveDate::with_year` `NaiveDate::with_month` `NaiveDate::with_day` `NaiveDate::with_ordinal` `NaiveTime::with_hour` `NaiveTime::with_minute` `NaiveTime::with_second` `NaiveTime::with_nanosecond` `NaiveDateTime::with_year` `NaiveDateTime::with_month` `NaiveDateTime::with_day` `NaiveDateTime::with_ordinal` `NaiveDateTime::with_hour` `NaiveDateTime::with_minute` `NaiveDateTime::with_second` `NaiveDateTime::with_nanosecond` `DateTime::with_year` `DateTime::with_month` `DateTime::with_day` `DateTime::with_ordinal` `DateTime::with_time` `DateTime::with_hour` `DateTime::with_minute` `DateTime::with_second` `DateTime::with_nanosecond` `DateTime::with_timezone` Time-rs...
Wow, that is a fast decision :smile:. But I think it is going to be a nice improvement. > Let's introduce the new names on main with deprecations? Those deprecations...
> I mean, it will still be churn if we change them only in 0.5, except that will be a lot more churn all at the same time? Better to...
> BTW I do kind of like the `assume_` prefixes from time-rs because they IMO more clearly/explicitly convey the intended semantics. So maybe we should copy those instead of `in_()`?...