Paul Dicker

Results 345 comments of Paul Dicker

Put a couple of hours into self-review and improving the initial documentation.

@djc You gave an approval, but want to have a final look?

I would like to start small, to keep things reviewable: - methods the create a `CalendarDuration` - methods to get the data back out - a `Display` implementation (to make...

The natural order to add a `CalendarDuration` to a some value is to first add the `months` component, and then the `days` component, and then the accurate component. What to...

About parsing ISO 8601 durations with a fractional component: > b) If necessary for a particular application, the lowest order components may have a decimal fraction. The decimal fraction shall...

They define it to be unsigned: https://www.iso.org/obp/ui/en/#iso_std_iso_8601-1_ed-1_v1_en_term_3.1.1.8 > **Duration** > non-negative quantity of time equal to the difference between the final and initial [instants (3.1.1.3)](https://www.iso.org/obp/ui/en/#iso:std:iso:8601:-1:ed-1:v1:en:term:3.1.1.3) of a [time interval (3.1.1.6)](https://www.iso.org/obp/ui/en/#iso:std:iso:8601:-1:ed-1:v1:en:term:3.1.1.6)

> Do you want to make the fields public of keep them private? I prefer to make them private, like in `std::time::Duration` and `chrono::Duration`. Then we can validate `nanos` <...

Currently I am reading up a bit more on our leap seconds issues. It seems like it really shouldn't be much work to implement a TAI timezone and do correct...

Your comments made me realize the situation with leap seconds is different from days that are not always 24h, months that differ in length, and leap years. For those three...

> I do not have access to ISO 8601 (I think it's not freely available? Beyond the definitions that are freely available, it does not do much more than specify...