bounter icon indicating copy to clipboard operation
bounter copied to clipboard

Mimic the Counter interface

Open piskvorky opened this issue 8 years ago • 3 comments
trafficstars

Wrap the low-level implementations (min count sketch, hash tables for key iteration...) in a Counter interface. The goal is to make Counter <-> Bounter switch trivial for users.

Methods that cannot be implemented due to algorithmic constraints (key iteration with min count sketch etc) should raise a NotImplementedError with a clear error message.

piskvorky avatar Sep 02 '17 15:09 piskvorky

@isamaru what's the status here? Are we raising NotImplementedError consistently?

If not, can you list what needs to be done, so others can take this over?

piskvorky avatar Oct 25 '17 20:10 piskvorky

I would be interested to pick this up. We just need to refactor the API to make it similar to Counter, right?

souravsingh avatar Dec 24 '17 17:12 souravsingh

@souravsingh yes, but please finish your current sLDA project first.

menshikh-iv avatar Dec 26 '17 04:12 menshikh-iv