tty-spinner icon indicating copy to clipboard operation
tty-spinner copied to clipboard

Publish new release

Open andrcuns opened this issue 4 years ago • 8 comments
trafficstars

Hi,

I have been using spinner in one of my projects and it works great, however I could really use some of the latest master branch additions, mainly:

  • log method to print above spinner
  • tty? method which seems to be private in the released version.

Have you considered pushing a new release any time soon?

andrcuns avatar May 05 '21 19:05 andrcuns

Hi Andrejs 👋

Thanks for using this gem in your project.

My plan was to look at the timer and multi-spinner issues. However, there is no reason why I cannot make this release earlier. I will see what I can do.

piotrmurach avatar May 05 '21 19:05 piotrmurach

@andrcuns This is still on my list and I plan to make a release this coming weekend.

piotrmurach avatar May 20 '21 20:05 piotrmurach

Hi @piotrmurach! Thanks for making this (and the other cool parts of tty). I'd also benefit from a new release, instead of relying on master in my Gemfiles. Can I help with the release somehow?

jgarth avatar Jan 17 '22 15:01 jgarth

@jgarth Yes, you can. The log method isn't fully robust for release. Here's the Spinner breaks on multiline message issue that needs resolving. My last comment summarises the problem and possible solutions. Once this is addressed, I think we will be in a good place to cut a new release.

piotrmurach avatar Jan 30 '22 12:01 piotrmurach

Also if you'd release we could use the 🚨 lighthouse-spinner https://github.com/piotrmurach/tty-spinner/commit/ee6651a115f32731f253d359468afdb53917a40f ;) And thanks for all the tty!

fwolfst avatar Oct 26 '22 10:10 fwolfst

+1

NielsKSchjoedt avatar Nov 06 '23 09:11 NielsKSchjoedt

If the methods are not available, the README documentation should at least reflect that they are either not available but planned or they should be. removed from the README completely.

I added this patch to my code for a log method:

module TTY
  class Spinner
    # Log a message to the output
    # This will clear the current spinner line, print the log message,
    # and then redraw or resume the spinner on a new line.
    #
    # @param [String] message
    #   the log message to print
    #
    # @api public
    def log(message)
      synchronize do
        clear_line    # Clear the spinner
        output.puts(message) # Log the message
        redraw_indent # Redraw the spinner frame
      end
    end
  end
end

MadBomber avatar Jan 21 '24 23:01 MadBomber