loaf icon indicating copy to clipboard operation
loaf copied to clipboard

Crumbs are never current on POST

Open benny-burkhart opened this issue 4 years ago • 1 comments

Describe the problem

Crumbs are never current when rendered on a response to e.g. an HTTP Post.

Steps to reproduce the problem

Render the same crumbs in response to HTTP POST and GET request.

Actual behaviour

On GET, some crumbs can be current, and others not. On POST, crumbs are never current.

Expected behaviour

Respect the behaviour configured using :match.

Describe your environment

  • OS version: MacOS Big Sur
  • Ruby version: 2.7
  • Loaf version: 0.10

This line here might be reasonably blunt: https://github.com/piotrmurach/loaf/blob/v0.10.0/lib/loaf/view_extensions.rb#L69

Reckons? Thanks!

benny-burkhart avatar Oct 04 '21 21:10 benny-burkhart

Hi Benjamin,

Thanks for using loaf and reporting this issue.

This is considered in a pull request - https://github.com/piotrmurach/loaf/pull/50

If you have any comments/thoughts let us know.

piotrmurach avatar Feb 21 '22 21:02 piotrmurach