github icon indicating copy to clipboard operation
github copied to clipboard

Support new deployment statuses

Open 3clypse opened this issue 4 years ago • 1 comments
trafficstars

👋 First of all, thanks for the project.

Issue

I saw that the gem doesn't support the deployment statuses: in_progress or queued.

The reason is because instead of sending 'application/vnd.github.cannonball-preview+json', they require application/vnd.github.flash-preview+json in the Accept header for these statuses while are in beta.

Tests

I checked that using application/vnd.github.flash-preview+json in all deployments requests made (list N deployments, get a status from a deployment, ...) worked like a charm. I assume that's the only change it needs.

Docs

  • https://docs.github.com/en/free-pro-team@latest/rest/reference/repos#list-deployment-statuses-preview-notices
  • https://developer.github.com/changes/2018-10-16-deployments-environments-states-and-auto-inactive-updates/#new-deployment-status-states
  • https://developer.github.com/changes/2014-11-25-the-deployments-api-is-official/

3clypse avatar Dec 11 '20 15:12 3clypse

Hi David,

Thanks for submitting the issue report.

You can either provide accept header value with your request or submit PR to get this changed.

piotrmurach avatar Dec 15 '20 11:12 piotrmurach