Piotr Murach

Results 145 comments of Piotr Murach
trafficstars

Thanks for using this gem! Please submit PR implementing new API and I will release quickly.

@Geekfish Please be assured I haven't forgotten about this and it's still on my list. My attention went temporarily to releasing other tty projects. I will do a final review...

Hi @Geekfish, I will review shortly as I'm easing myself back into things. I was in an accident, hence my absence from open source for some time. I was meant...

As for `enum_select` prompt. Agreed, not having help text and labels makes adding `:confirm_keys` far less useful. My thoughts were to fully allow what the `:confirm_keys` accepts in the other...

@Geekfish Thank you for investigating! That's a weird way for the `case` to be broken on `jruby` and well done on figuring it out. I believe we're ready to merge?...

@Geekfish Thank you. I'd change the subject line to be more specific regarding keys. There is another idea to have custom keys for selecting items which I'd like to be...

@Geekfish Ahh yes, Ruby probably 'thinks' this is a block rather than a hash argument. All changes look good, only `List#confirm_keys` is missing a comment.

@Geekfish Thanks! As they say, the nth+1 is the charm 😄

@fdiaz My attention has been shortly diverted to releasing other projects. I appreciate your enthusiasm for this feature and be assured it will be merged soon. @Geekfish I do apologise,...

Hi @Geekfish, nice one! Nearly there. There are still few issues left to do with the yardoc. I think it's best if you run the `yard` tool and see the...