Piotr Murach

Results 145 comments of Piotr Murach
trafficstars

I don't think this will ever be `fixed`. Before the change, I was calling `gets` on the output streams. That's pretty dangerous in many instances. Firstly, it **always** waits for...

@jrochkind It's not necessarily a matter of receiving a newline character. `gets` stops reading also when the scripts exist or the writing pipe is closed. Most importantly, the colouring output...

@jrochkind I really don't think an option is a right way to go. That would blossom the complexity of pretty printer even further and would only work in rare cases...

Hmmm streaming vs buffering printer... I suppose we could have `:stream_output` option by default set to `true`... Does anyone fancy submitting PR?

I like it! The only thing I'm still unsure is how to handle the option. I'm swaying more in the direction of having an actual new printer called `pretty_bufferred` or...

@jrochkind The reason I thought about having a new printer type as opposed to an extra option that applies neither to the command logic nor to all printers, it is...

Sorry, I've had a full day travel to Japan and soon will be speaking at RubyKaigi about tty libs etc.... This is just to say that I may be a...

@thisismydesign I'd like to resolve this issue... I know it's been a while... do you have time to submit PR with your suggestion?

Hi Vlad, Thanks for using the gem! This is not surprising behaviour given how `tty-spinner` works; it only clears the current terminal line it is displayed on. By default, a...

I like the idea. The `tty-progressbar` gem already supports similar [:elapsed](https://github.com/piotrmurach/tty-progressbar#41-tokens) token, you can check it out for inspiration. I don't necessarily aim to mirror token naming but some parity/similarity...