pingostack
Testing offer
This is not really an issue - more an offer to look at how to put in place more extensive testing.
I've been looking at using this module a bit more (Thanks for putting on the BSD license, btw)
A couple of minor issues in building and testing in my organization, but overcome - and I'll submit a pull request as soon as I can get approval.
Can you say how you've been testing this code - both from the point of view of ensuring that it compiles against the latest Nginx sources and confirming that the websocket API is being fully implemented?
I'd like to offer some possible ways of putting regression testing in place - I'm a big fan of integration testing - so mostly exercising the API from its public interface, while also making sure that internal resources are being cleaned up as they should.
Looking into that, there are some prerequisites: a way to build the module into a nominated Nginx server version, as well as a lightweight websocket client that can confirm correct external behaviour.
For the former, including a build step in the test, and for the latter also building a lightweight websocket client like libuwsc as part of the test would probably be necessary.
What do you think?
Note: I'm not pushing any particular technology here - just the ability to test against new versions of Nginx core, for example.
I added a pull request with a test that I think may suit. I also have some pending changes I'd separately like to merge that aim to implement the 'close handshake' for the websocket protocol
Hi,
Thank you for submitting the pull request and the additional test. I have merged your changes and also appreciate your pending changes to implement the 'close handshake' for the WebSocket protocol. Your offer to implement more extensive testing capabilities is also welcomed.
Looking forward to seeing your upcoming contributions.
Best regards.
