tidb-operator
tidb-operator copied to clipboard
pingcap
[DNM] pdms: Choose a suitable pdms to transfer primary when upgrade
What problem does this PR solve?
What is changed and how does it work?
Code changes
- [ ] Has Go code change
- [ ] Has CI related scripts change
Tests
- [ ] Unit test
- [ ] E2E test
- [ ] Manual test
- [ ] No code
Side effects
- [ ] Breaking backward compatibility
- [ ] Other side effects:
Related changes
- [ ] Need to cherry-pick to the release branch
- [ ] Need to update the documentation
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
Codecov Report
Attention: Patch coverage is 3.50877% with 110 lines in your changes missing coverage. Please review.
Project coverage is 33.08%. Comparing base (
9ef26f8) to head (d02d9b8). Report is 13 commits behind head on master.
:exclamation: There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (d02d9b8). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (d02d9b8) unittest 1 0
Additional details and impacted files
@@ Coverage Diff @@
## master #5643 +/- ##
===========================================
- Coverage 61.47% 33.08% -28.39%
===========================================
Files 235 219 -16
Lines 30653 30611 -42
===========================================
- Hits 18843 10127 -8716
- Misses 9920 19087 +9167
+ Partials 1890 1397 -493
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 33.08% <3.50%> (?) |
|
| unittest | ? |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csuzhangxc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [csuzhangxc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![ti-chi-bot[bot] avatar](https://avatars.githubusercontent.com/in/214286?v=4 "Published by a pub.dev verified publisher"){kind=small}
[LGTM Timeline notifier]
Timeline:
2024-08-13 09:26:04.210377006 +0000 UTC m=+260048.913846641: :ballot_box_with_check: agreed by csuzhangxc.
@csuzhangxc: new pull request created to branch release-1.6: #5709.
In response to this:
/cherry-pick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.
