ossinsight icon indicating copy to clipboard operation
ossinsight copied to clipboard

Published 20 hours ago • verified publisher icon pingcap

Data Explorer: Question is too long error shoud be handled

Open Mini256 opened this issue 2 years ago • 2 comments

Bug Report

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
image image

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Mini256 avatar Jul 07 '23 03:07 Mini256

👋🏼 @Mini256, @634750802 I've raised the PR #1666 which should fix this 🚀

Siddhant-K-code avatar Oct 24 '23 08:10 Siddhant-K-code

@Siddhant-K-code I tested it online, and the problem still exists.I will re-open this issue.

Since the title is too long, the question is not created, so the front-end can't get question?.status and the subsequent error determination logic is not executed.

https://github.com/pingcap/ossinsight/blob/dfbf7ff4709cfe26d3dfb63a14b874ee56a610f8/web/src/pages/explore/_components/SqlSection/ErrorMessage.tsx#L18

@634750802 will be fixed it on pingcap/ossinsight-next repo.

Mini256 avatar Oct 25 '23 06:10 Mini256