monitoring icon indicating copy to clipboard operation
monitoring copied to clipboard

Outdated files and dependencies

Open dveeden opened this issue 3 years ago • 4 comments

This repo seems to contain a lot of outdated and unmaintained things

  • monitor-snapshot/ seems to be years old copies of files
  • monitor/ seems very old (v4.0.0-beta.2 seems to be the most recent version)
  • cmd/main.go seems to be dependent on https://github.com/pingcap/tidb-ansible
  • cmd/montioring.go seems to be dependent on https://github.com/pingcap/tidb-ansible
  • platform-monitoring/ansible/ ansible specific
  • pkg/ansible/ ansible specific
  • README.md still mentioned the old ansible things. Mentions very old versions of TiDB.

A LICENSE file seems to be missing and none of the *.go files seem to have a copyright header.

dveeden avatar Oct 26 '22 16:10 dveeden

@Ehco1996 @KanShiori @better0332 @amyangfei What do you think is the right way to get this fixed?

dveeden avatar Oct 26 '22 16:10 dveeden

There are many pull requests from the SRE bot, which seem to indicate more that this isn't really maintained.

dveeden avatar Oct 26 '22 16:10 dveeden

https://deps.dev/go/github.com%2Fpingcap%2Fmonitoring/v6.4.0-alpha%2Bincompatible indicates issues.

cc @lulukelu

dveeden avatar Oct 27 '22 07:10 dveeden

There are many pull requests from the SRE bot, which seem to indicate more that this isn't really maintained.

I closed them. And now the <branch> dir in the release branches and master branch will be automatic updated.

wuhuizuo avatar Apr 26 '24 14:04 wuhuizuo