docs-cn icon indicating copy to clipboard operation
docs-cn copied to clipboard

develop: fix paging sql with multiple columns for cluster index table

Open Mini256 opened this issue 3 years ago • 2 comments

First-time contributors' checklist

What is changed, added or deleted? (Required)

Change the paging SQL example with multiple columns for the cluster index table.

The old example will make a bad full table scan, the new one can use indexes.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • [x] master (the latest development version)
  • [x] v6.2 (TiDB 6.2 versions)
  • [x] v6.1 (TiDB 6.1 versions)
  • [ ] v5.4 (TiDB 5.4 versions)
  • [ ] v5.3 (TiDB 5.3 versions)
  • [ ] v5.2 (TiDB 5.2 versions)
  • [ ] v5.1 (TiDB 5.1 versions)
  • [ ] v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from: https://github.com/pingcap/docs/pull/10478
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • [ ] Delete files
  • [ ] Change aliases
  • [ ] Need modification after applied to another branch
  • [ ] Might cause conflicts after applied to another branch

Mini256 avatar Sep 19 '22 16:09 Mini256

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Sep 19 '22 16:09 ti-chi-bot

@Icemap @winoros PTAL

Oreoxmt avatar Sep 20 '22 07:09 Oreoxmt

/hold

Need to change further.

Mini256 avatar Oct 11 '22 06:10 Mini256

/unhold

@Icemap @winoros PTAL again, thanks!

Mini256 avatar Oct 24 '22 16:10 Mini256

@Oreoxmt, thanks for your review!

Mini256 avatar Oct 25 '22 04:10 Mini256

/remove-status LGT1 /status LGT2 /merge

Oreoxmt avatar Jan 18 '23 06:01 Oreoxmt

This pull request has been accepted and is ready to merge.

Commit hash: eb3871dbe86fcfe01aadb26a35e63aded597f41b

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.4: #12725.

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs-cn#release-6.5 from head ti-chi-bot:cherry-pick-11341-to-release-6.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.1: #12726.

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.2: #12727.

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

In response to a cherrypick label: new pull request created to branch release-6.3: #12728.

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot

/cherry-pick release-6.5

Oreoxmt avatar Jan 18 '23 06:01 Oreoxmt

@Oreoxmt: new pull request created to branch release-6.5: #12729.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Jan 18 '23 06:01 ti-chi-bot