Permission to bring changes upstream

[manishrjain]

trafficstars

Hey guys,

You're doing some pretty interesting work on Badger. Kudos!

Curious: Are you guys using Badger at Pingcap?

Also, what license are your changes under? Can the Badger team bring back some of these optimizations that you have done, so we can improve Badger for all users?

Cheers, Manish (Badger author)

[coocood]

@manishrjain

Thank you for your excellent project.

We use badger in an experimental project, not used in production yet.

The license is still APACHE LICENSE 2.0.

Of course, you can bring the optimizations back to the upstream, just reference our PR or commit link in the backport commit message would be enough.

[manishrjain]

Thanks, we'll bring some of these optimizations back. If you can point us to the most important ones, that'd be very helpful.

How is Badger's performance in your experiments?

[coocood]

@manishrjain The most important optimization is the SST format change and table iterator, merge iterator. The scan performance has improved multiple times, even faster than RocksDB.

[manishrjain]

Nice. Pointers to some relevant commits?

[coocood]

The initial fork picked this optimization https://github.com/dgraph-io/badger/pull/481

And then those are the related PRs, the earlier ones are more important.

https://github.com/coocood/badger/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+optimize