st7789-python icon indicating copy to clipboard operation
st7789-python copied to clipboard

ST7789V Variant?

Open nebhead opened this issue 1 year ago • 4 comments
trafficstars

Any plans to support the ST7789V variant?

nebhead avatar Jun 14 '24 18:06 nebhead

I'd say the chances are somewhere above zero if I got my hands on one. Unfortunately most of the work on this library is driven by product requirements, and I don't have any such requirements, nor much free time at the moment!

Pull requests would be graciously accepted.

Gadgetoid avatar Jun 17 '24 12:06 Gadgetoid

I added the variant: https://github.com/mander1000/st7789-python

Unfortunately I also switched from gpiod to RPi.GPIO (as RPi.GPIO uses MIT and not LGPL) and added a function to deactivate and (re-)activate the display (as I wanted to switch the display on/off later). What do you want to merge? ;)

mander1000 avatar Aug 09 '24 10:08 mander1000

As weird and painful as it is, you should be using the Linux standard gpiod. Anything else is either wrong, broken, soon to be broken, slow, or just uses gpiod under the hood anyway.

MIT vs LGPL is largely irrelevant when the entire OS is GPL anyway 😆

Gadgetoid avatar Aug 09 '24 10:08 Gadgetoid

thanks @mander1000 a lot for the work!

I took the opportunity to extract only the part for ST7789V from the larger commit and create a PR for it

https://github.com/pimoroni/st7789-python/pull/38

Hope it is clear there, that this is all your work and credits should got to you 😊

alangecker avatar May 30 '25 19:05 alangecker