Pim Jansen

Results 68 comments of Pim Jansen
trafficstars

@localheinz can you review the source since my german is lacking here. Imo the code looks good enough so

@jaapromijn i dont think this commit breaks the unique constraint here. It executes an extra flush on Doctrine ORm when it hits the batchsize. However i see you grab a...

@jaapromijn correct however since all is flushed already, clearing and detaching it should not be a problem? Can you explain the use case, since looking at the code you are...

@jaapromijn ok but where is then the unique constraint coming from? Since i dont see you use a check to prevent that?

Could someone create a patch PR for this? Lets revert the clear due to sidefx then.

My cents: **PHP version** I would really like to kick off fresh by starting with 7.4. I know it will not be backwards compatible but that is the same with...

@localheinz i was thinking about how we can handle the locales and seperate packages where the faker core still holds its value. For example if i have a `carrier` which...

@fzaninotto agree! One thing i however did not mention yet is the ORM integration there is. Are we going to keep that or pull that and maybe publish it as...

> i can help with laravel ORM Good to hear @ManojKiranA. Once we have a first beta of the `Faker core` i think its time to think about how to...

@joelharkes not sure if this is 100% the case but if so i agree. The seed should be isolated for each instance on its own indeed