pimcore icon indicating copy to clipboard operation
pimcore copied to clipboard

Published 20 hours ago • verified publisher icon pimcore

Add translation to the field title for csv and xlsx export

Open kevinloeber-twocream opened this issue 1 year ago • 8 comments

Changes in this pull request

Added that when exporting csv or xlsx files, the translation of the column names is specified and not the normal name

Additional info

So that the CSV and XLSX export in the GridView displays the names of the fields as column names. There is an adjustment to the input mask of the exports with a checkbox whether you want to use the field titles. There is also an adjustment to the export process to translate the field titles.

kevinloeber-twocream avatar Jul 15 '24 14:07 kevinloeber-twocream

Review Checklist

  • [x] Target branch (11.2 for bug fixes, others 11.x)
  • [ ] Tests (if it's testable code, there should be a test for it - get help)
  • [ ] Docs (every functionality needs to be documented, see here)
  • [ ] Migration incl. install.sql (e.g. if the database schema changes, ...)
  • [ ] Upgrade notes (deprecations, important information, migration hints, ...)
  • [x] Label
  • [x] Milestone

github-actions[bot] avatar Jul 15 '24 14:07 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 25 '24 20:07 CLAassistant

Thank you for your PR! Could you please sign the CLA and trigger a recheck?

kingjia90 avatar Aug 27 '24 09:08 kingjia90

recheck

kevinloeber-twocream avatar Aug 27 '24 11:08 kevinloeber-twocream

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Aug 29 '24 09:08 sonarqubecloud[bot]

Hey @kevinloeber-twocream I tried to test it, but could not make it work.

How should the translation work in general? I tried it with label and also system key but it never got translated.

mattamon avatar Aug 29 '24 09:08 mattamon

Hey @mattamon , I have added two text fields in my data model as an example, which have a translation key as a label. When I add the fields in the grid view, the translations are displayed in Pimcore, but when I export the grid view as csv, only the translation keys are displayed and not the translations. Pimcore: image image image Export: image

kevinloeber-twocream avatar Sep 03 '24 07:09 kevinloeber-twocream

@kevinloeber-twocream hmm okay I switched to your branch and still does not get translated for me.

mattamon avatar Sep 11 '24 07:09 mattamon

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Dec 13 '24 08:12 sonarqubecloud[bot]