perspective-editor
perspective-editor copied to clipboard
Cleanup MenuItemPermissionHelper.js: Removed definitions and moving to bundles
Solves #134.
As I see since 1.8.0 support for Pimore 10.0 is dropped out. So, looks like time is come and PR contains removing permission definitions from here and and adding to related Pimcore bundles. I plan moving items to bundles and clean translation file for en only - based on the same thing as it was described in previous PR #157, but translations still present on another locales. So, might be it should be clean up and require re-import phrases?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Hello @vmalyk , thank you so much for all the changes. Unfortunately, merging the other prs resulted in a merge conflict in this pr. Could you please have a quick look?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Hello @vmalyk , never mind, I was able to resolve the conflict. Failing test is about the missing secret, it should be fine after merging it back into the base branch.
Thanks!