ustreamer icon indicating copy to clipboard operation
ustreamer copied to clipboard

Minor regression in 6.13: make fails when pkg-config isn't found

Open yurivict opened this issue 1 year ago • 4 comments

Build in the VM failed because pkg-config wasn't present:

==>  Building for ustreamer-6.13
Makefile:21: *** recipe commences before first target.  Stop.
===> Compilation failed unexpectedly.

This is a minor problem, but I am still reporting it.

yurivict avatar Aug 16 '24 04:08 yurivict

It's needed for gpio, drm and janus plugin.

mdevaev avatar Aug 16 '24 19:08 mdevaev

Yes, but gmake fails ungracefully when pkg-config is accidentally missing.

yurivict avatar Aug 16 '24 19:08 yurivict

Could you check the latest master? It should be checked correctly.

mdevaev avatar Aug 17 '24 02:08 mdevaev

The latest commit fails gracefully:

===>  Building for ustreamer-6.13
Makefile:21: *** "No pkg-config found in /usr/local/libexec/ccache:/usr/ports/multimedia/ustreamer/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin".  Stop.
===> Compilation failed unexpectedly.

yurivict avatar Aug 17 '24 08:08 yurivict

It seems like the best thing I can do right now. In the future, I will have to completely revise the build system and maybe use autotools or something else.

mdevaev avatar Sep 04 '24 15:09 mdevaev

It's needed for gpio, drm and janus plugin.

I'm wondering, why the dependency check in the Makefile does not check for these flags to be set. If it's only needed for gpio, drm and janus couldn't you check for WITH_GPIO=1, WITH_SYSTEMD=1 and WITH_JANUS=1?

I was also a bit confused as this new dependency wasn't added to the readme yet, but that was only an oversight I guess.

mryel00 avatar Feb 27 '25 18:02 mryel00

I simply forgot about it. I've just added pkg-config to README.

As for the optional dependency on pkg-config, it's easier to always require it because my Makefile is far from perfect.

mdevaev avatar Feb 27 '25 20:02 mdevaev

Ok, thank you for the fast answer and adding it to the README 😄

mryel00 avatar Feb 27 '25 20:02 mryel00

👌

mdevaev avatar Feb 27 '25 20:02 mdevaev