Pierre Theo Klein

Results 21 comments of Pierre Theo Klein

The benefit of `is` is that the type of the variable is immediately understood. Definitely worth looking up some naming conventions from large TS projects and using that as inspiration...

Thanks for this! Cool to see the backend converted to TS. I would personally push to separate out each of these bullet points into separate PRs, because they seem unrelated...

@krubenok spitballing here, but it'll be some expansion of the current schema (if not a copy of it). I'm pretty sure that the existing schema can be ported to SQL...

You would have to look at git blame to potentially figure out why we had the createdAt field. Maybe it was to invalidate duplicate (older) reset tokens? If you don't...

@brarsanmol can you elaborate on why gavel is better for picking small numbers of winners? I'm not familiar with the algo so don't know the implication of picking large numbers...

This is definitely a massive undertaking

Why are we storing the template in mongoDB, and not an S3 bucket?

What user stories are we trying to implement? Is the idea that marketing folks can send out email blasts from the website itself?

Is there a PR for this?

- This requires a documentation change, so run `npm run docs` or something of that sort. - Make sure to write a few test calls to your API!