refactor: move nested sass declarations after non-nested declarations
This PR fixes #577 by reordering some sass declarations to work with the new rules for mixed declarations. See https://sass-lang.com/documentation/breaking-changes/mixed-decls for more info.
Sad at the number of files that needed touching but happy that you might have uncovered the issue and solved it.
If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.
This is a great PR to be honest, I was getting the same issue and was going to create the PR, but @nstringham already did it. Awesome! When do we get this?
I'm currently using "@picocss/pico": "^2.0.6", within my npm workspace.
What version of picocss do we need to update to, to overcome these Deprecation Warnings?
What version of picocss do we need to update to, to overcome these Deprecation Warnings?
You need to wait until this PR is merged.
If you want I can move
color-schemedown so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.
just a super nit. I think it's great!
@lucaslarroche Can you look at this please? This warnings are very annoying!
Hey @nstringham, Thanks a lot! I tested this, and it’s a really nice fix.
This will allow us to remove sass --silence-deprecation=mixed-decls, which is great. I’ll merge this into dev.
It will be shipped with the next release.
Appreciate the contribution!
Thanks!