pico icon indicating copy to clipboard operation
pico copied to clipboard

refactor: move nested sass declarations after non-nested declarations

Open nstringham opened this issue 1 year ago • 6 comments

This PR fixes #577 by reordering some sass declarations to work with the new rules for mixed declarations. See https://sass-lang.com/documentation/breaking-changes/mixed-decls for more info.

nstringham avatar Aug 18 '24 17:08 nstringham

Sad at the number of files that needed touching but happy that you might have uncovered the issue and solved it.

bunnymatic avatar Aug 20 '24 03:08 bunnymatic

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

nstringham avatar Aug 20 '24 03:08 nstringham

This is a great PR to be honest, I was getting the same issue and was going to create the PR, but @nstringham already did it. Awesome! When do we get this?

tirthbodawala avatar Aug 27 '24 05:08 tirthbodawala

I'm currently using "@picocss/pico": "^2.0.6", within my npm workspace.

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

blachawk avatar Sep 05 '24 13:09 blachawk

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

You need to wait until this PR is merged.

nstringham avatar Sep 05 '24 13:09 nstringham

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

just a super nit. I think it's great!

bunnymatic avatar Sep 05 '24 18:09 bunnymatic

@lucaslarroche Can you look at this please? This warnings are very annoying!

yeganemehr avatar Nov 23 '24 10:11 yeganemehr

Hey @nstringham, Thanks a lot! I tested this, and it’s a really nice fix.

This will allow us to remove sass --silence-deprecation=mixed-decls, which is great. I’ll merge this into dev. It will be shipped with the next release.

Appreciate the contribution!

lucaslarroche avatar Mar 09 '25 13:03 lucaslarroche

Thanks!

nstringham avatar Mar 09 '25 15:03 nstringham