Add option to close guider upon clicking outside

[mattflaschen]

This adds an option, defaulted to false. If it is true, the guider will close if you click outside of it.

[mattflaschen]

There's a required bug fix to unbind this event when the guider hides. If you're interested in merging the feature, let me know, and I'll update the pull request.

[pickhardt]

Yes, I plan to include it in the next version. It's a good catch. Can you send the addition?

Jeff Pickhardt Sent from my Android On Jan 22, 2013 6:58 PM, "Matt Flaschen" [email protected] wrote:

There's a required bug fix to unbind this event when the guider hides. If you're interested in merging the feature, let me know, and I'll update the pull request.

— Reply to this email directly or view it on GitHubhttps://github.com/jeff-optimizely/Guiders-JS/pull/87#issuecomment-12579322.

[mattflaschen]

Great. There's actually one more fix to this pull request. I'm going to get it reviewed on our side, then bundle it into this one too.

[mattflaschen]

I've redone this against the dev branch. It adds the unbind fix, and another to avoid "losing" the first click when they click outside, but the overlay is not visible.

I also refactored the close code into _handleOnClose.

[deepthawtz]

is this PR still being considered?

[pickhardt]

Yes, I've just been pretty busy, but this is a good pull request. Thanks Matt for submitting it.

[zackshapiro]

@pickhardt Wanted to +1 the request for click outside to close. Was going to implement it myself but since it's an outstanding PR, I'll wait for the merge.

[michaelklem]

+1