phpstan-symfony icon indicating copy to clipboard operation
phpstan-symfony copied to clipboard

The constant_hassers not working as constantHassers default of extension.neon always used

Open alexander-schranz opened this issue 2 years ago • 0 comments

The extension is setting:

		constant_hassers: true
		constantHassers: true

in our libraries which we had phpstan update it still uses:

		constant_hassers: true

But this seems not has longer any effects based on the code here:

https://github.com/phpstan/phpstan-symfony/blob/b9e1deda86b1c72eb0fcbf1cee836d71ccaf36bc/src/Symfony/Configuration.php#L26

I think constant_hassers never has any effects as constantHassers is still always true. So this BC Layer seems not to work maybe extension.neon should go with:

		constant_hassers: null
		constantHassers: null

What do you think?

alexander-schranz avatar Oct 18 '23 13:10 alexander-schranz