phpstan
Support for `ServiceProviderInterface`
@ondrejmirtes I've added support for ServiceProviderInterface and checked it against our codebase - after my changes and implementing this interface in our locators (mentioned here) I don't have errors, so rule is working properly.
But I had tough time with this mostly because of test scenario provided in #151 which IMHO does not work as expected. I started by adding ExampleController::privateServiceFromServiceProvider() but wanted to make it fail and I couldn't. After several tries I just checked what will happen if I remove $isServiceLocator from ContainerInterfacePrivateServiceRule and... tests were still green. So I've just removed those services from tests/Rules/Symfony/container.xml completely and I would like to provide proper test cases for service locator/provider but I don't know how 😅 I've tried to create some example files, loaded in new test method within ContainerInterfacePrivateServiceRuleTest, but I did not manage to achieve failing scenario, which could be fixed by my changes. Could you help me with this (or @lookyman)?
@ondrejmirtes I described it in the PR's description 🤷♂️ I really would like to provide proper test cases, but I had hard time with that and just asked for help here.