phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

fix DOMDocument::createTextNode return type

Open medilies opened this issue 2 years ago • 5 comments
trafficstars

medilies avatar Nov 19 '23 19:11 medilies

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

phpstan-bot avatar Nov 19 '23 19:11 phpstan-bot

I don't understand why this failed

medilies avatar Nov 19 '23 20:11 medilies

The failures are unrelated to your PR, but please rebase this on top of 1.10.x as the bot says.

ondrejmirtes avatar Nov 20 '23 08:11 ondrejmirtes

please tell me how you rebased it :p

medilies avatar Nov 20 '23 09:11 medilies

I didn't, I just changed the base here in the UI.

What you need to do on your side is to rebase your commit on top of 1.10.x. Something like this:

git rebase --onto origin/1.10.x HEAD^

And then force-push it.

ondrejmirtes avatar Nov 20 '23 09:11 ondrejmirtes

bruh

medilies avatar May 06 '24 09:05 medilies