phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Replace ArrayType::castToArrayKey() with Type::toArrayKey()

Open rvanvelzen opened this issue 3 years ago • 1 comments
trafficstars

rvanvelzen avatar Oct 14 '22 09:10 rvanvelzen

All aboard the Type refactoring train! 🚆 I can't wait to get rid of inheritance in Type classes.

ondrejmirtes avatar Oct 14 '22 09:10 ondrejmirtes

The improvement actually causes some tests to fail legitimately, which is why I kept is as a draft. I'll improve those separately first so this can land cleanly :)

rvanvelzen avatar Oct 17 '22 12:10 rvanvelzen

ah right, I introduced usage of the old method again in the meantime in HasOffsetValueType, sorry 😊

herndlm avatar Oct 17 '22 12:10 herndlm

This pull request has been marked as ready for review.

phpstan-bot avatar Oct 17 '22 14:10 phpstan-bot

Thank you!

ondrejmirtes avatar Oct 17 '22 14:10 ondrejmirtes