phpstan-src Update `CallbackFilterIterator` stub.

Jun 22 '22 19:06 drupol

Why are you making these changes?

Jun 23 '22 07:06 ondrejmirtes

After some more thinking, I think those methods are not relevant because we are inheriting from FilterIterator. Going to make a commit to remove them: https://phpstan.org/r/159f7749-5b6b-409f-939e-958879348c95

Jun 23 '22 07:06 drupol

Why are you making these changes? Why the iterators shouldn't have covariant template types?

Jun 23 '22 07:06 ondrejmirtes

@ondrejmirtes Without the -covariant suffix, this is failing.

What do you advise here?

Jun 23 '22 15:06 drupol

/cc @arnaud-lb I have a question for you - am I right that @template-covariant parameter in a constructor is not a problem and should not be reported? Here's a reproduction: https://phpstan.org/r/f5a5d99b-a62b-4c81-8325-09984d8cef43

Jun 23 '22 15:06 ondrejmirtes

/cc @arnaud-lb I have a question for you - am I right that @template-covariant parameter in a constructor is not a problem and should not be reported? Here's a reproduction: https://phpstan.org/r/f5a5d99b-a62b-4c81-8325-09984d8cef43

Agreed, this should not be reported for the constructor

Jun 24 '22 10:06 arnaud-lb

Hi, I'm cleaning up old and stale PRs. Please send a new PR if you're still interested, thanks.

Oct 16 '22 10:10 ondrejmirtes