phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

Published 20 hours ago • verified publisher icon phpstan

Implement locateIdentifiersByType for OptimizedSingleFileSourceLocator

Open tomasfejfar opened this issue 3 years ago • 2 comments

Followup to #1080

tomasfejfar avatar Mar 24 '22 22:03 tomasfejfar

@ondrejmirtes I kind of extrapolated from https://github.com/phpstan/phpstan-src/pull/1080#issuecomment-1072411687. It felt weird that if I'm looking in directory constants are not located, but when I look at single file, they are.

tomasfejfar avatar Mar 30 '22 09:03 tomasfejfar

I just want locateIdentifier() and locateIdentifiersByType() to be consistent in each locator.

ondrejmirtes avatar Mar 30 '22 13:03 ondrejmirtes

I took it over the finish line, thanks.

ondrejmirtes avatar Oct 26 '22 09:10 ondrejmirtes