phpstan-deprecation-rules icon indicating copy to clipboard operation
phpstan-deprecation-rules copied to clipboard

Strange behavior

Open martenb opened this issue 3 years ago • 0 comments

Hi, I have problem with depracation rules in GitLab CI. I have following code

<?php declare(strict_types = 1);

namespace App\Core\Controls\Base\Grid;

use Nette\ComponentModel\IContainer;
use Nette\Localization\Translator;

class GridFactory
{

	protected Translator $translator;

	public function __construct(Translator $translator)
	{
		$this->translator = $translator;
	}

	public function create(?IContainer $parent = null, ?string $name = null): Grid
	{
		$grid = new Grid($parent, $name);
		$grid->setTranslator($this->translator); // problematic line
<?php declare(strict_types = 1);

namespace App\Core\Controls\Base\Grid;

use Ublaboo\DataGrid\DataGrid;

class Grid extends DataGrid
{
}

DataGrid is external library, in setTranslator, it accepts depracated ITranslator. So i added it to ignore. On local is everthing ok, but in GitLab CI, i am getting following error.

 Ignored error pattern #^Parameter \#1 \$translator of method           
         Ublaboo\\DataGrid\\DataGrid\:\:setTranslator\(\) expects               
         Nette\\Localization\\ITranslator, Nette\\Localization\\Translator      
         given\.$#

On local and CI i have same PHP version. Any suggestioins???

martenb avatar Aug 10 '22 05:08 martenb