phpdoc-parser icon indicating copy to clipboard operation
phpdoc-parser copied to clipboard

Support for `@pure-unless-parameter-passed`

Open staabm opened this issue 1 year ago • 1 comments

refs https://github.com/phpstan/phpstan/issues/11884#issuecomment-2426297188

staabm avatar Nov 18 '24 15:11 staabm

We already have other similar implementation lined up. There's @pure-unless-callable-is-impure which is implemented in the parser (https://github.com/phpstan/phpdoc-parser/pull/253) but not yet in PHPStan (https://github.com/phpstan/phpstan-src/pull/3482).

It's not a great look when there's a tag understood by the parser but not by the analyser. I'd like to minimize that coming into the future. It'd be nice to also have the implementation ready in phpstan-src before merging the parser countepart.

I will look at this again when https://github.com/phpstan/phpstan-src/pull/3482 is merged and the implementation for @pure-unless-parameter-passed is ready in phpstan-src.

ondrejmirtes avatar Jan 15 '25 09:01 ondrejmirtes