phpdoc-parser icon indicating copy to clipboard operation
phpdoc-parser copied to clipboard

Published 20 hours ago • verified publisher icon phpstan

Remove $trimStrings from ConstExprParser

Open rvanvelzen opened this issue 3 years ago • 3 comments

Per https://github.com/phpstan/phpdoc-parser/pull/143#issuecomment-1281099895

rvanvelzen avatar Oct 20 '22 07:10 rvanvelzen

This should be fine for the next major as it is a BC break.

rvanvelzen avatar Oct 20 '22 07:10 rvanvelzen

I think we could decouple phpdoc-parser version from PHPStan so we could release 2.0 now and update to it in PHPStan 1.x :) On the other hand, this would be a PHPStan-userland BC break too, so it might not be a good idea...

ondrejmirtes avatar Oct 20 '22 07:10 ondrejmirtes

Just checked in PHPStan and for PHPStan users it's not really a BC break because it's already called with true. The only exception are @method tags and that's fine...

ondrejmirtes avatar Oct 20 '22 08:10 ondrejmirtes