pecl-system-sync icon indicating copy to clipboard operation
pecl-system-sync copied to clipboard

replaced obsolete macro AC_TRY_LINK

Open determin1st opened this issue 1 year ago • 3 comments

determin1st avatar Jul 05 '24 21:07 determin1st

Please explain what the actual issue is here. The software built fine for me under the PHP 8.3.x source tree earlier this year (IIRC, around March 2024) and the extension still passed all tests in the test suite when I tested it. Obsolete is not necessarily broken. Something labeled obsolete might break in the future but that's a problem to deal with in the future if it actually breaks. Assuming that ever happens. Many things get labeled in software development as obsolete and then they just stay that way until the heat death of the universe.

The extension itself has a bunch of other "obsolete" code in it that allows it to cross-compile the extension all the way back to PHP 5.3 - a version which is long past EOL but was being supported at the time it was written. This extension probably still compiles under PHP 5.3 with all the other correct system libraries in place to build that version of PHP. Is that a good idea? Probably not. However, as long as it successfully compiles, works, passes all tests, and isn't causing any actual problems (i.e. runtime crashes, corrupting memory, etc.), then there's probably no harm in leaving the extension's C source as-is. AC_TRY_LINK() was, at one point, the PHP way of doing things in M4 and it wasn't an obsolete macro at the time.

cubiclesoft avatar Jul 09 '24 15:07 cubiclesoft

ive just seen some warnings during compilation and decided to test how github works :]] ive read that warnings pollute screen so you waste attention on them, so i wasted a bit

there was another warning about AC_PROG_LIBTOOL but its probably in phpize http://blog.jdlh.com/en/2022/03/31/ac-prog-libtool-is-obsolete/

extension's C source as-is.

i thought it was C++ source/tool. no problems close then. would be nice if you made windows binary for php 8.2.

determin1st avatar Jul 10 '24 00:07 determin1st

The Windows PECL DLL build system has been down for a really long time. There's an open issue on this issue tracker with a link to unofficial Windows binary builds of multiple PECL libraries. They aren't an official channel but I also haven't closed the issue as they do appear to be possibly trustworthy and appear to be in the same boat as other extension devs, which lends credence/legitimacy to what they are doing. Still, I generally recommend running unverified precompiled binaries/DLLs from unofficial locations through VirusTotal as a sanity check.

cubiclesoft avatar Jul 17 '24 03:07 cubiclesoft