http-message icon indicating copy to clipboard operation
http-message copied to clipboard

Add return typehints

Open Stilch opened this issue 4 years ago • 9 comments

Stilch avatar May 09 '21 07:05 Stilch

@weierophinney @pmjones Have we an approximate date of merge? We can't wait several years for each such release =)

McLotos avatar Jun 20 '21 19:06 McLotos

@weierophinney @gabidj I think this request is high time to merge with #83, then create a 2.0 version of http-message package.

McLotos avatar Jun 20 '21 19:06 McLotos

PHP 8.1 RC1 is out and here we are still waiting for a release for PHP 7.2+ with types :slightly_smiling_face:.

ADmad avatar Sep 08 '21 13:09 ADmad

Tumbleweed

ADmad avatar Dec 16 '21 13:12 ADmad

is this not maintained anymore? I would also love to see this PR merged

deluxetom avatar Feb 09 '22 17:02 deluxetom

is this not maintained anymore? I would also love to see this PR merged

It isn't a question of maintained or not. I'm not in a position to do anything about this package anymore. Making changes to any published PSR or its associated packages is a lengthy process.

I know @weierophinney already touched on this via Twitter, so I'm including this here for context. :)

Not too long ago, the mailing list was the preferred way to bring up topics related to existing or future PSRs. Looks like Discord is on the list, now, too.

https://www.php-fig.org/get-involved/

simensen avatar Feb 14 '22 21:02 simensen

Any of the methods that return an instance of the same interface (the "wither" methods) should ideally have a static return type since that is now available.

simensen avatar Feb 14 '22 21:02 simensen

I can add static return type, but I will have to set the minimum php version to 8.0

Stilch avatar Feb 16 '22 18:02 Stilch

Will we continue to wait new version or will leave it (not implement interface)? PHP 8.1 was released and PHP 7.4 Active support ended :( https://www.php.net/supported-versions.php

oanhnn avatar Apr 15 '22 10:04 oanhnn

It's end of 2022, php 8.2 is around the corner and still no resolution to this issue. Please abandon this project... it would be at least an answer we can work with.

ikkez avatar Oct 16 '22 13:10 ikkez

Would be nice if PHP-FIG also provides some clarification if the PSR repos are maintained by the group as a whole or each one is handled by a BDFL.

ADmad avatar Oct 18 '22 06:10 ADmad

Anew news on this?

cosminsandu avatar Feb 16 '23 14:02 cosminsandu

@ADmad —

clarification if the PSR repos are maintained by the group as a whole or each one is handled by a BDFL.

The bylaws make clear the chain of "power" for a given spec repo: editor, sponsor, then group.

I've been very slow on these, as I had quite some concerns about ecosystem impact. I've done testing on #94 at this point, and feel it's ready to go. I'm testing this one next, to determine impact for implementing libraries and existing consumers so I can write up a migration guide. When that's ready, we can start the evolution vote. I'm hoping to get that done in the next 1-4 weeks.

weierophinney avatar Feb 21 '23 22:02 weierophinney

@weierophinney thank you for testing this out and the detailed report. I am happy to start working on updating PSR-17 (and PSR-15) for this change.

shadowhand avatar Feb 21 '23 23:02 shadowhand

@shadowhand Awesome - I'll ping you if/when the vote passes!

weierophinney avatar Feb 22 '23 00:02 weierophinney