magento2-enqueue icon indicating copy to clipboard operation
magento2-enqueue copied to clipboard

Add support for enqueue 0.10

Open bfontaine opened this issue 2 years ago • 7 comments

Per https://github.com/php-enqueue/enqueue-dev/issues/1321#issuecomment-1798527799 (cc @makasim)

I’m not sure how to test this. The contribution guide in enqueue-dev mention commands that don’t exist in this repo (and it’s not listed as a split repo).

bfontaine avatar Nov 07 '23 17:11 bfontaine

I just saw this duplicates https://github.com/php-enqueue/magento2-enqueue/pull/7

bfontaine avatar Nov 13 '23 10:11 bfontaine

can you drop all versions except for 0.10 please? They are not supported.

makasim avatar Nov 13 '23 12:11 makasim

I’m not sure how to test this.

Let's update and see what happens

makasim avatar Nov 13 '23 12:11 makasim

ok, done.

bfontaine avatar Nov 13 '23 13:11 bfontaine

Well as-is it doesn’t work because of https://github.com/php-enqueue/enqueue-dev/issues/1136. This code was removed in https://github.com/php-enqueue/enqueue-dev/commit/ed707fe5 for 0.9.0. I’m not sure what to use now that it’s gone; I don’t see it in UPGRADE.md.

bfontaine avatar Nov 13 '23 14:11 bfontaine

Sorry, I don't remember what it was about.

makasim avatar Nov 13 '23 14:11 makasim

The Magento module depends on Enqueue\Symfony\Client\Meta\* classes, which were removed in 0.9.0.

bfontaine avatar Nov 13 '23 15:11 bfontaine