Buildalyzer icon indicating copy to clipboard operation
Buildalyzer copied to clipboard

Escape semicolon in property values

Open slang25 opened this issue 1 year ago • 2 comments

Fixes #271

slang25 avatar May 07 '24 12:05 slang25

It might be worth making the escape behaviour a bit more complete, opinions welcome: https://github.com/dotnet/msbuild/blob/ad4df597b038182ff632602c1e2f59f3ed131d76/src/Shared/EscapingUtilities.cs#L284-L310

slang25 avatar May 07 '24 12:05 slang25

@slang25 do you see a way to create a unit test for this scenario?

I believe this problem will not only happen with the ";"

phmonte avatar May 08 '24 21:05 phmonte

I'll follow up with some tests and a fuller PR soon 🙂

slang25 avatar May 13 '24 22:05 slang25

@slang25 do you see a way to create a unit test for this scenario?

I believe this problem will not only happen with the ";"

This happens because of how linux sh/bash interpreter works.

You only need to escape ";" "," and space.

softlion avatar May 29 '24 15:05 softlion