Multi-Agent-Deep-Deterministic-Policy-Gradients icon indicating copy to clipboard operation
Multi-Agent-Deep-Deterministic-Policy-Gradients copied to clipboard

Published 20 hours ago • verified publisher icon philtabor

Shouldn't it be agent.actor.forward() and calculate actor_loss?

Open VijiKK opened this issue 3 years ago • 0 comments
trafficstars

https://github.com/philtabor/Multi-Agent-Deep-Deterministic-Policy-Gradients/blob/a3c294aa6834f348a7401306dff3e67919c861f5/maddpg.py#L83

Dear Phill,

First of all plenty of thanks and gratitude for your lessens, I've learned a lot from your lectures. I've noticed a difference in the code at line 83 in MADDPG class while calculating actor-loss. It's running forward propagation of critic network instead of actor network. I believe this is typo, please correct me if I'm wrong.

Thanks and Regards Viji

VijiKK avatar Jun 13 '22 14:06 VijiKK