Phillip Krüger

Results 247 comments of Phillip Krüger
trafficstars

Yes Optional or OptionalInt should also work. @dicolasi that might be a clean solution than checking the -1 on the int value.

I was under the impression that they are ?!? At least there are this : https://github.com/smallrye/smallrye-graphql/blob/910d920003c6a564478ddfcaf00fa747a97421e9/server/implementation/src/main/java/io/smallrye/graphql/scalar/number/IntegerScalar.java#L39 You you have a test case where this fails ?

Good suggestion ! Thanks. We can look at this a.s.a.p, or alternatively you can provide a PR :)

Thanks @Felk - let's keep this open for the `@Name` part

Thanks for the feature request. We will look at this a.s.a.p. You are also welcome to supply a PR :) .

Also see https://openliberty.io/blog/2019/01/24/async-rest-jaxrs-microprofile.html as an possible way to do it. (Thanks @andymc12 )

Sounds good to me. Our CI build and release is in .github folder as we are using GitHub actions. So maybe see if you can fix it there ?

Hi @marceloverdijk. Yes let me check with @kenfinnigan and/or @radcortez .