terraform-aws-github-runner icon indicating copy to clipboard operation
terraform-aws-github-runner copied to clipboard

Published 20 hours ago • verified publisher icon philips-labs

feat: Log job runtime for `completed` events (#3687)

Open winwinashwin opened this issue 1 year ago • 6 comments

Closes #3687

winwinashwin avatar Jan 04 '24 10:01 winwinashwin

@npalm Could you please review?

winwinashwin avatar Jan 05 '24 07:01 winwinashwin

@npalm Any comments on this?

winwinashwin avatar Jan 08 '24 06:01 winwinashwin

Thanks for the PR, I have some huge backlog. Doing my best to dig in the PR asap.

npalm avatar Jan 10 '24 20:01 npalm

@winwinashwin, can you add a quick test case for this change?

GuptaNavdeep1983 avatar Feb 05 '24 17:02 GuptaNavdeep1983

I will check the PR asap. sorry for the delay

npalm avatar Feb 08 '24 14:02 npalm

@GuptaNavdeep1983 From the comment under the linked issue I thought adding the runtime computation logic in the lambda was discouraged in favour of the experimental event bridge, which is why I refrained from working further on this PR.

If you are okay with merging this change please make it clear so that I can work on this, else I understand your decision and we can close this PR.

winwinashwin avatar Feb 10 '24 13:02 winwinashwin

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 12 '24 01:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 13 '24 01:04 github-actions[bot]