script.toolbox icon indicating copy to clipboard operation
script.toolbox copied to clipboard

Text viewer problem when using empty header

Open Hitcher opened this issue 9 years ago • 7 comments

Currently if you don't want a header by leaving it empty but you previously ran textviewer that had a header value then the old value will be displayed.

PS The notes about escaping info need updating.

Hitcher avatar Feb 02 '16 08:02 Hitcher

Ping @sualfred

Hitcher avatar Feb 02 '16 08:02 Hitcher

Noticed it aswell. And with Marcels implementation, too. It seems that this is an Kodi issue, because the label id="1" won't be cleared on unload.

sualfred avatar Feb 02 '16 11:02 sualfred

What happens if this script sets it as empty if we don't supply a header value?

Hitcher avatar Feb 02 '16 11:02 Hitcher

My Pythons skills are very very very low but the script sets the header value even if no value is provided. That's why I think that this is a Kodi issue.

sualfred avatar Feb 02 '16 11:02 sualfred

Thanks mate, hopefully Phil will be able to help.

Hitcher avatar Feb 02 '16 11:02 Hitcher

@HitcherUK https://github.com/sualfred/skin.ftv/commit/1a61e9c3af03397728132ba9495c84b49b63603c

Small workaround ;)

sualfred avatar Feb 02 '16 12:02 sualfred

Haha, I was thinking of a similar fix but would rather not have to mess with the DialogTextViewer if it can be helped.

Hitcher avatar Feb 02 '16 12:02 Hitcher